bneradt commented on PR #476: URL: https://github.com/apache/trafficserver-ci/pull/476#issuecomment-6225067898
Reviewed 22d0e1e: no blocking findings; this looks reasonable to merge. Checked all 28 pipelines: the retry/backoff policy is consistent, and branch selection, refspecs, shallow depth, and PR merge settings are preserved. `git diff --check` passes. The timeout ordering is correct: Jenkins allows `retry` to rerun after a nested `timeout` expires ([RetryStepExecution](https://github.com/jenkinsci/workflow-basic-steps-plugin/blob/1098.v808b_fd7f8cf4/src/main/java/org/jenkinsci/plugins/workflow/steps/RetryStepExecution.java#L93), [TimeoutStepExecution](https://github.com/jenkinsci/workflow-basic-steps-plugin/blob/1098.v808b_fd7f8cf4/src/main/java/org/jenkinsci/plugins/workflow/steps/TimeoutStepExecution.java#L253)). The 4-minute `CloneOption` timeout applies to Git clone/fetch operations, while the 5-minute Pipeline timeout bounds the entire checkout attempt, including the PR merge ([CloneOption](https://github.com/jenkinsci/git-plugin/blob/git-5.10.1/src/main/java/hudson/plugins/git/extensions/impl/CloneOption.java)). Validation limitation: there are no attached CI checks, and I did not execute these pipelines in Jenkins. The description reports controller lint validation; actual retry execution remains untested. I'd watch the first branch and PR runs after merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
