RajaMuhammadAwais opened a new pull request, #13855:
URL: https://github.com/apache/trafficserver/pull/13855

   Fixes (https://github.com/apache/trafficserver/issues/13851)]
   
   The `rate_limit` plugin incorrectly rejected TLS connections for clients 
configured in an SNI limiter’s `exclude` list. Although the documentation 
states that excluded client IPs should bypass rate limiting, the existing 
implementation treated them as rejected clients by calling:
   
   
   ```kotlin
   TSVConnReenableEx(vc, TS_EVENT_ERROR);
   return TS_ERROR;
   
   ```
   
   As a result, excluded clients received no HTTP response and `curl` returned 
HTTP code `000`.
   
   ### Root Cause
   
   The exclusion path used the same error handling as rate-limit rejection. 
This caused the TLS handshake to terminate instead of continuing normally.
   
   ### Fix
   
   The exclusion path now follows the same control flow as an SNI without a 
limiter:
   
   
   ```
   TSVConnReenable(vc);
   break;
   
   ```
   
   This allows excluded clients to complete the TLS handshake and bypass rate 
limiting without affecting normal limiter behavior.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to