Copilot commented on code in PR #13858:
URL: https://github.com/apache/trafficserver/pull/13858#discussion_r4318410745
##########
src/proxy/http/HttpTransact.cc:
##########
@@ -3063,6 +3063,9 @@ HttpTransact::HandleCacheOpenReadHit(State *s)
}
// override the default version with what the server has
http_version = s->current.server->http_version;
+ } else {
+ handle_parent_down(s);
+ return;
Review Comment:
Indentation in the newly added `else` block is inconsistent with the
surrounding indentation (the `handle_parent_down` / `return` lines appear
over-indented relative to nearby blocks). Please align these lines with the
existing indentation style in this function to keep formatting consistent and
avoid future merge/format churn.
##########
src/proxy/http/HttpTransact.cc:
##########
@@ -3063,6 +3063,9 @@ HttpTransact::HandleCacheOpenReadHit(State *s)
}
// override the default version with what the server has
http_version = s->current.server->http_version;
+ } else {
+ handle_parent_down(s);
+ return;
Review Comment:
PR description refers to `s->current_server`, but the code change is
guarding `s->current.server`. If `current_server` is just a shorthand in the
description, consider updating the PR description to match the actual member
name to avoid confusion during review/debugging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
