tmt-123 commented on PR #13850:
URL: https://github.com/apache/trafficserver/pull/13850#issuecomment-6284010629
Thanks for the review and independent verification. Addressed the
non-blocking suggestions in be578aa:
- Guard timestamp lookup with isinstance(session, dict), with regressions
for non-empty list and string sessions.
- Log the actual timestamp key and use %s for its value.
- Search all captured log lines instead of relying on the first message.
The existing zero-timestamp fallback behavior is preserved. The broader
worker exception and exit-status handling is left for a separate follow-up.
The expanded regression suite fails against ae9139b with 5 failures and
3 errors, and passes with these changes on Windows and Debian 12. It
covers 10 incomplete-session variants through both the function and CLI,
plus a valid-session control. Full CTest passed 1135/1135, and the project
format target and pre-commit checks passed.
Could you please take another look and check whether the required Jenkins
checks need to be triggered for the updated head?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
