bryancall commented on PR #13869:
URL: https://github.com/apache/trafficserver/pull/13869#issuecomment-6306707180

   #13545 moved this test to Uranium, so I merged master and moved the fix into 
`tests/uranium_tests/cache/test_proxy_serve_stale_dns_fail.py`. The mechanism 
is the same as before: `max_stale_age` is 300 on both proxies, and the two 
checks that expect a copy to be too old send `X-Stale-Window: narrow`, which a 
header_rewrite rule on the localhost maps turns into a one-second window for 
that request. The 17 second sleeps are gone. The AuTest file this PR used to 
edit no longer exists, so the diff is now only the Uranium file.
   
   I reran the proof against the Uranium test:
   
   | Test | Change | Failed |
   |---|---|---|
   | master | none | 0/4 |
   | master | 20 s stall before the first check | 4/4 (500 where 200 is 
expected) |
   | this PR | none | 0/4 |
   | this PR | 20 s / 40 s stall | 0/4 / 0/4 |
   | this PR | wide window set to 1 s | 3/3 |
   | this PR | narrow window set to 300 s | 3/3 |
   | this PR | `X-Stale-Window` header not sent | 3/3 |
   
   Could you take another look?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to