JosiahWI commented on code in PR #13881:
URL: https://github.com/apache/trafficserver/pull/13881#discussion_r4338966777
##########
src/iocore/cache/CacheVC.cc:
##########
@@ -675,10 +675,10 @@ CacheVC::removeEvent(int /* event ATS_UNUSED */, Event *
/* e ATS_UNUSED */)
}
}
ink_assert(!stripe || this_ethread() != stripe->mutex->thread_holding);
- _action.continuation->handleEvent(CACHE_EVENT_REMOVE_FAILED,
reinterpret_cast<void *>(-ECACHE_NO_DOC));
+ _action.call_back(CACHE_EVENT_REMOVE_FAILED, reinterpret_cast<void
*>(-ECACHE_NO_DOC));
goto Lfree;
Lremoved:
- _action.continuation->handleEvent(CACHE_EVENT_REMOVE, nullptr);
+ _action.call_back(CACHE_EVENT_REMOVE, nullptr);
Review Comment:
We can reason from the code that the action is not cancelled at this point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
