bryancall commented on code in PR #13873:
URL: https://github.com/apache/trafficserver/pull/13873#discussion_r4340498164
##########
tests/uranium_tests/h2/test_http2.py:
##########
@@ -198,8 +200,9 @@ def test_http2_active_timeout(ats_factory: ATSFactory,
services: ServiceFactory)
TEST_DIRECTORY / "h2active_timeout.py",
str(_ats.https_port),
"/",
- "4",
- timeout=10,
+ str(ACTIVE_TIMEOUT),
+ # Longer than the 15 seconds h2active_timeout.py waits for the close.
+ timeout=30,
Review Comment:
Agreed, and it's the same point Damian raised earlier. Fixed in 5d63c6d71b:
the test now has its own `MAX_WAIT = ACTIVE_TIMEOUT + 5`, passes it as
`--max_wait`, and sets the step timeout to `MAX_WAIT + 10`. That tightens the
bound from 15 to 8 seconds. On hera it passed 30 of 30 runs, 20 of them with
every core busy, and it fails 3 of 3 with the wait set to 3 seconds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
