Copilot commented on code in PR #13884:
URL: https://github.com/apache/trafficserver/pull/13884#discussion_r4342941647
##########
tests/urtest.sh.in:
##########
@@ -31,5 +31,5 @@ exec python3
"@CMAKE_CURRENT_SOURCE_DIR@/tools/uranium/runner.py" configured \
"--verifier-bin=@PROXY_VERIFIER_PATH@" \
"--sandbox=@URTEST_SANDBOX@" \
"--project-directory=@CMAKE_CURRENT_BINARY_DIR@" \
- "${curl_uds_argument[@]}" \
+ ${curl_uds_argument[@]+"${curl_uds_argument[@]}"} \
Review Comment:
This `${var[@]+...}` idiom is correct for `set -u` + unset arrays in older
Bash, but it’s fairly opaque. To keep the script easier to maintain, consider
either (a) adding a short comment explaining that macOS Bash 3.2 errors on
`${curl_uds_argument[@]}` when unset under `set -u`, or (b) initializing
`curl_uds_argument` to an empty array earlier (e.g., `curl_uds_argument=()`) so
the call site can remain the simpler `\"${curl_uds_argument[@]}\"`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
