Copilot commented on code in PR #13579: URL: https://github.com/apache/trafficserver/pull/13579#discussion_r4347989297
########## src/proxy/http/unit_tests/test_HttpSessionManager.cc: ########## @@ -0,0 +1,345 @@ +/** @file + + Unit tests for ServerSessionPool::acquireSession. + + @section license License + + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. + */ + +#include "proxy/http/HttpSessionManager.h" +#include "proxy/http/HttpConfig.h" + +#include <catch2/catch_test_macros.hpp> + +#include <cstring> +#include <memory> +#include <vector> + +namespace +{ + +/** A minimal PoolableSession that can be pooled and matched. + * + * Only the remote address and the hostname hash participate in the match + * paths exercised here, so no NetVConnection is required. The session must + * not be multiplexing, otherwise acquireSession consults the HttpSM. + */ +class TestPoolableSession : public PoolableSession +{ +public: + TestPoolableSession(char const *addr_str, char const *hostname) + { + ink_release_assert(ats_ip_pton(addr_str, &_remote_addr) == 0); + this->attach_hostname(hostname); + } + + void + new_connection(NetVConnection *, MIOBuffer *, IOBufferReader *) override + { + } + void + start() override + { + } + void + release(ProxyTransaction *) override + { + } + void + destroy() override + { + } + void + free() override + { + } + void + increment_current_active_connections_stat() override + { + } + void + decrement_current_active_connections_stat() override + { + } + + int + get_transact_count() const override + { + return 0; + } + + const char * + get_protocol_string() const override + { + return "test"; + } + + IOBufferReader * + get_remote_reader() override + { + return nullptr; + } + + void + do_io_close(int /* lerrno ATS_UNUSED */ = -1) override + { + ++close_count; + } + + sockaddr const * + get_remote_addr() const override + { + return &_remote_addr.sa; + } + + int close_count = 0; + +private: + IpEndpoint _remote_addr; +}; + +/// Owns the test sessions and hands raw pointers to the pool under test. +class SessionFactory +{ +public: + TestPoolableSession * + make(char const *addr_str, char const *hostname) + { + return _sessions.emplace_back(std::make_unique<TestPoolableSession>(addr_str, hostname)).get(); + } + +private: + std::vector<std::unique_ptr<TestPoolableSession>> _sessions; +}; + +/// The pool bookkeeping updates this gauge, which is normally initialized via HttpConfig. +/// Create it here (when needed) and reset it on entry and on every exit path so tests don't leak state. +class PooledConnectionsGaugeGuard +{ +public: + PooledConnectionsGaugeGuard() + { + if (http_rsb.pooled_server_connections == nullptr) { + http_rsb.pooled_server_connections = Metrics::Gauge::createPtr("proxy.process.http.pooled_server_connections"); + } + Metrics::Gauge::store(http_rsb.pooled_server_connections, 0); + } + + ~PooledConnectionsGaugeGuard() { Metrics::Gauge::store(http_rsb.pooled_server_connections, 0); } Review Comment: This guard unconditionally overwrites a process-global gauge to 0 on entry and exit. In a single test binary, that can interfere with other unit tests that rely on this metric (or run concurrently), and it can also mask leaks by always forcing the value back to 0. Prefer saving the prior gauge value in the constructor and restoring it in the destructor (and only creating the gauge if needed), so the test is isolated and doesn’t perturb unrelated tests. ########## src/proxy/http/unit_tests/test_HttpSessionManager.cc: ########## @@ -0,0 +1,345 @@ +/** @file + + Unit tests for ServerSessionPool::acquireSession. + + @section license License + + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. + */ + +#include "proxy/http/HttpSessionManager.h" +#include "proxy/http/HttpConfig.h" + +#include <catch2/catch_test_macros.hpp> + +#include <cstring> +#include <memory> +#include <vector> Review Comment: This test file uses several non-standard/project types and functions (e.g., Metrics::Gauge, CryptoContext/CryptoHash, IpEndpoint, ats_ip_pton, ink_release_assert) that appear to compile only via transitive includes from HttpSessionManager/HttpConfig. To make the unit test more robust against header refactors, include the direct headers that declare the symbols used in this file instead of relying on transitive inclusion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
