moonchen commented on PR #13754: URL: https://github.com/apache/trafficserver/pull/13754#issuecomment-6348360594
Thanks, Bryan. - NUL in `records[]`: `prometheus_record_filter()` now drops a decoded name that contains a NUL, because no record name has one. A query whose only names are dropped still counts as a `records[]` request, so it gets an empty body, not the full output. The unit tests cover a `%00` in the middle and at the end of a name. - String metrics: the docs now say that a string metric, such as `proxy.process.version.server.short`, cannot be found by its name, so a response has it only after the plugin has seen it in a walk of every record. The `record_exists()` comment says the same. I also rebased onto master after #13545 and moved this PR's tests to Uranium. The AuTests became pytest modules or `.test.yaml` replays, and the two tests that #13545 converted took this PR's changes. Each commit builds and passes its own tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
