cmcfarlen commented on code in PR #13657:
URL: https://github.com/apache/trafficserver/pull/13657#discussion_r4353729693
##########
plugins/experimental/rate_limit/limiter.h:
##########
@@ -202,7 +202,7 @@ template <class T> class RateLimiter
}
if (node["rate"]) {
- _limit = node["rate"].as<uint32_t>();
+ _rate = node["rate"].as<uint32_t>();
Review Comment:
This fixes a real bug from #11271 (in 10.1.0 onward): `rate` used to
overwrite `_limit`, and no bucket was created. But it changes what existing
configs do — the documented example (`limit: 1000`, `rate: 200`) currently
behaves as a 200 active-transaction cap with no rate limit, and after this it
becomes a 1000 cap plus a 200/s new-session limit. Could you add that to the
upgrading notes (and mention it in the description)? It might also be worth its
own PR so it can be considered for 10.2.x independently of the strict-key
change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
