brbzull0 opened a new pull request, #13930: URL: https://github.com/apache/trafficserver/pull/13930
#9415 changed the default of `restricted_api` in `jsonrpc.yaml` to `false`. It updated the code, the example in `configs/jsonrpc.yaml.default` and the example block in the admin guide. Two places still describe the old default: the `restricted_api` row of the field table in `doc/admin-guide/files/jsonrpc.yaml.en.rst` says "``true`` by default", and the comment on `restrictedAccessApi` in `include/mgmt/rpc/server/IPCSocketServer.h` calls `0700` the default. The same doc page already shows `restricted_api: false` as the default configuration, so it contradicts itself. This PR: - states `false` as the default in the table row; - describes both settings as `IPCSocketServer::bind()` and `late_check_peer_credentials()` implement them: with `false`, the socket is created `0777` and restricted calls are accepted only from root or from the user Traffic Server runs as; with `true`, the socket is created `0700`; on platforms without peer credentials the socket is always created restricted; - fixes the header comment. What this PR does not do: change any default or behaviour. Docs and a comment only. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
