maskit commented on code in PR #13919:
URL: https://github.com/apache/trafficserver/pull/13919#discussion_r4417149391
##########
plugins/experimental/ja4_fingerprint/plugin.cc:
##########
@@ -268,6 +270,18 @@ log_fingerprint(JA4_data const *data)
}
}
+// Only QUIC sends the quic_transport_parameters extension (RFC 9001, section
8.2).
+JA4::Protocol
+get_protocol(TSClientHello ch)
+{
+ unsigned char const *buf{};
+ std::size_t buflen{};
+ if (TS_SUCCESS == TSClientHelloExtensionGet(ch,
EXT_QUIC_TRANSPORT_PARAMETERS, &buf, &buflen)) {
Review Comment:
What if somebody sends the extension on TCP/TLS connection? A malicious QUIC
connection may not send the extension on purpose, although the handshake would
fail. This should be based on the type of connections.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
