maskit commented on code in PR #13942:
URL: https://github.com/apache/trafficserver/pull/13942#discussion_r4418716391
##########
tests/uranium_tests/tls/test_tls_client_versions.py:
##########
@@ -46,7 +45,9 @@ def configure_ats(ats_factory: ATSFactory, openssl_version:
str) -> ATS:
"ECDHE-RSA-AES256-SHA384:AES128-GCM-SHA256:AES256-GCM-SHA384:ECDHE-RSA-RC4-SHA:"
"ECDHE-RSA-AES128-SHA:ECDHE-RSA-AES256-SHA:RC4-SHA:RC4-MD5:AES128-SHA:AES256-SHA:"
"DES-CBC3-SHA!SRP:!DSS:!PSK:!aNULL:!eNULL:!SSLv2")
- version = re.search(r"\d+(?:\.\d+)+", openssl_version)
+ # BoringSSL reports itself as OpenSSL 1.1.1 and rejects the whole list if
Review Comment:
Not a blocker but they may change the version number in the near future. We
may want to detect non-OpenSSL forks.
https://issues.chromium.org/issues/497675628
I also think we can drop OpenSSL 1.x support on ATS 11.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
