maskit commented on PR #13956:
URL: https://github.com/apache/trafficserver/pull/13956#issuecomment-6585053074
Since this PR changes what `pqssr` means in practice, could you also update
its description in `doc/admin-guide/logging/formatting.en.rst` (line 747 on
master)? It currently says:
```rst
pqssr Proxy Request SSL session ticket reused status from |TS| to the
origin;
indicates if the current request hit the SSL session
ticket
and avoided a full SSL handshake.
```
Two things are off:
- It describes a session *ticket*, but the value comes from the origin
session cache. A cached `SSL_SESSION` can resume by session ID or by ticket,
depending on the TLS version and the origin.
- "hit the SSL session ticket" reads like a cache hit, which is the behavior
this PR removes. After this change, a cache hit that the origin declines logs 0.
Suggested wording:
```rst
pqssr Proxy Request 1 if the connection from |TS| to the origin resumed a
TLS
session from the origin session cache (see
:ts:cv:`proxy.config.ssl.origin_session_cache.enabled`),
avoiding a full TLS handshake. 0 if no cached session
was
offered or the origin declined it.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
