JosiahWI commented on code in PR #13968:
URL: https://github.com/apache/trafficserver/pull/13968#discussion_r4454751842
##########
plugins/experimental/mp4/mp4.cc:
##########
@@ -123,6 +123,11 @@ TSRemapDoRemap(void * /* ih ATS_UNUSED */, TSHttpTxn rh,
TSRemapRequestInfo *rri
}
buf_len = snprintf(buf, sizeof(buf), "%.*s%.*s", left, query, right, query +
query_len - right);
+ if (buf_len < 0 || buf_len >= static_cast<int>(sizeof(buf))) {
Review Comment:
Nit: It would be more robust to widen `buf_len` rather than narrowing `buf`,
but the buffer is well under INT16_MAX so this is not a blocker.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
