bneradt commented on PR #13838: URL: https://github.com/apache/trafficserver/pull/13838#issuecomment-6643990982
@bryancall thanks for the approval. I applied all three non-blocking notes and rebased on master in bbac58e260: 1. **HTTP/3 over QMux**: `save_session_fingerprint` now skips sessions whose first protocol tag (the negotiated ALPN) starts with `h3` or `hq`, which covers `h3`, `h3-29`, `h3qx-01`, and the HTTP/0.9 `hq` ALPNs that HQSession also serves. It compares only the prefix because quiche's ALPN buffer is not NUL-terminated. The debug line is now "on HQ session", and `test_jax_fingerprint_log_field_http3` checks for it. 2. **`method_name`**: `SessionFingerprints::Entry::method_name` is now a `std::string`, so it no longer depends on the lifetime of the plugin instance's config. 3. **`excludes: "JA4H: -"`**: added `line_count_min: 2` so the check waits for both transactions. Built with `ci-fedora-urtest`. The jax_fingerprint and logging urtests pass: 41 passed, 4 skipped, including the HTTP/3 test. I didn't run QMux itself. The push dismisses nothing automatically, but your approval is on the old head, so it may need a refresh. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
