bryancall commented on PR #14003: URL: https://github.com/apache/trafficserver/pull/14003#issuecomment-6671419091
Thanks for the ping, Ishan. The one failure in URTest 2of3 is the new test this PR adds. The first transaction passes, but the redirect check fails: ``` FAILED tests/uranium_tests/pluginTest/header_rewrite/header_rewrite_remap_url.test.yaml::header_rewrite_remap_url - client exited with status 1; expected [0]. [INFO]: Equals Violation: Different. Key: "2", Field Name: "location", Correct Value: "http://redirect.ex/new/";, Actual Value: "http://redirect.ex/"; HTTP/1.1 302 Redirect Location: http://redirect.ex/ ``` This test has failed on every commit you pushed today, and it isn't one of the tests we see fail at random, so a re-run won't help. I think the cause is the `%{PATH}` in `first.conf`. header_rewrite has no `PATH` condition, so it logs `Unknown condition PATH` when it loads the config and drops that part of the value, which leaves the redirect with an empty path. The header_rewrite docs say the old `%{PATH}` no longer works and point to `%{CLIENT-URL:PATH}` instead ([URL parts](https://docs.trafficserver.apache.org/en/latest/admin-guide/plugins/header_rewrite.en.html)). Since this test checks the remapped URL and your `cond` already reads `%{URL:PATH}`, I'd use `%{URL:PATH}` in the redirect too, which should give you `http://redirect.ex/new/` with your change. Your next push will run CI again on its own. On the logs: the CI server doesn't allow anonymous reads right now, so there's no public view of the console, and I don't know of a mirror. Until that changes, ask here and one of us will paste the failure for you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
