I'm not sure, can you give some background on your original MySQL version and GitLab version?
Please let me know if you have any questions or comments. Best regards, Sytse Sijbrandij CEO GitLab B.V. On Fri, Sep 19, 2014 at 4:15 PM, Matthew Fleming <matthewdflem...@gmail.com> wrote: > Thanks for the quick reply. Well the db was setup in accordance with the > instructions. The db itself was set to utf8 character set and > utf8_unicode_ci collation. We didn't manually create the tables or anything > like that; I think the application is a rails app that does db migrations on > startup. So the question is whoever 'creates' the merge_request_diffs table, > didn't make this table with utf8. I'm just wondering how that happens? > > -Matt > > On Sep 19, 2014, at 8:51 AM, Sytse Sijbrandij <sy...@gitlab.com> wrote: > > I think your MySQL tables where set up with the incorrect character set. > > Please let me know if you have any questions or comments. > > Best regards, > Sytse Sijbrandij > CEO GitLab B.V. > > > On Fri, Sep 19, 2014 at 3:47 PM, Matthew Fleming > <matthewdflem...@gmail.com> wrote: > > So here's the reason that unicode/utf-8 chars are bombing gitlab merge > requests: > > ActiveRecord::StatementInvalid (Mysql2::Error: Incorrect string value: > '\xE2\x86\xB4 \n...' for column 'st_diffs' at row 1: UPDATE > `merge_request_diffs` SET `state` = 'collected', `st_diffs` > > The issue is that the merge_request_diffs table is not set to accept utf8 > characters. > > -Matt > > On Sep 3, 2014, at 10:14 AM, Matthew Fleming <matthewdflem...@gmail.com> > wrote: > > Right.. that does seem like it would cover it. I'm gonna check on the > install that was done here (the guy who maintains the system is out until > tomorrow). I'm gonna check the db settings and the > > -Matt > > On Sep 3, 2014, at 9:52 AM, Sytse Sijbrandij <sy...@gitlab.com> wrote: > > Mmm, sounds like a MySQL problem, should be covered with: > > mysql> CREATE DATABASE IF NOT EXISTS `gitlabhq_production` DEFAULT CHARACTER > SET `utf8` COLLATE `utf8_unicode_ci`; > > from > https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/install/database_mysql.md > > > On Wed, Sep 3, 2014 at 3:59 PM, Matthew Fleming <matthewdflem...@gmail.com> > wrote: > > > I can try to write the test case but in the past the problem was just > about creating the mysql database "properly". I can maybe get the admins to > update the mysql db to support utf8 but here's how you would do that in a > create script (I'm not sure how gitlab creates the db).. > > CREATE DATABASE db_name > CHARACTER SET utf8 > DEFAULT CHARACTER SET utf8 > COLLATE utf8_general_ci > DEFAULT COLLATE utf8_general_ci > ; > > -Matt > > On Sep 3, 2014, at 8:05 AM, Sytse Sijbrandij <sy...@gitlab.com> wrote: > > Hi Matt, > > I think you are right, this is probably a GitLab or MySQL problem. I don't > have an idea to solve it, it would be great if someone could write a failing > test case for it. > > Sytse > > > On Wed, Sep 3, 2014 at 3:01 PM, Matthew Fleming > <matthewdflem...@gmail.com> wrote: > > > Also the git commit locally had no issues, nor did the push to the > server. What failed was the generation of the pull request due to an insert > problem with mysql handling utf-8 characters. > > -Matt > > On Sep 3, 2014, at 4:19 AM, sytse <sy...@gitlab.com> wrote: > > Git can't handle UTF-8 characters in the branch as far as I know. > > > On Friday, August 29, 2014 3:57:59 PM UTC+2, Matthew Fleming wrote: > > > Hey there, > > We are getting a 500 error when creating merge/pull requests from a > branch that contains UTF-8 characters in the change log. Mysql freaks out > about the unicode characters and doesn't allow the merge request to be > written to the db. When I removed the utf8 chars things worked properly. > Interestingly, the merge request to my own master branch (I was on a feature > branch) was successful, so I'm thinking there is a slightly different path > taken there. When I submitted the merge request across repositories it > always failed however (until the character was removed). > > -Matt > > > > -- > You received this message because you are subscribed to a topic in the > Google Groups "GitLab" group. > To unsubscribe from this topic, visit > https://groups.google.com/d/topic/gitlabhq/IIFsrJo_nV8/unsubscribe. > To unsubscribe from this group and all its topics, send an email to > gitlabhq+unsubscr...@googlegroups.com. > > To view this discussion on the web visit > https://groups.google.com/d/msgid/gitlabhq/8081bdc4-b8ec-4822-ad5d-9124da56864c%40googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > > > > -- > You received this message because you are subscribed to the Google Groups > "GitLab" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to gitlabhq+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/gitlabhq/939B13C2-70FB-4560-AA24-F455D850115E%40gmail.com. > > For more options, visit https://groups.google.com/d/optout. > > > > > -- > You received this message because you are subscribed to a topic in the > Google Groups "GitLab" group. > To unsubscribe from this topic, visit > https://groups.google.com/d/topic/gitlabhq/IIFsrJo_nV8/unsubscribe. > To unsubscribe from this group and all its topics, send an email to > gitlabhq+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/gitlabhq/CAJTzhG-FDoWJ%2By-ndF9z%2B%2BiwYu5tGjfEKSbGGo4demGr-XMnnQ%40mail.gmail.com. > > For more options, visit https://groups.google.com/d/optout. > > > > -- > You received this message because you are subscribed to the Google Groups > "GitLab" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to gitlabhq+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/gitlabhq/A3F40666-497B-4120-9ECB-FD98B9272610%40gmail.com. > > For more options, visit https://groups.google.com/d/optout. > > > > > -- > You received this message because you are subscribed to a topic in the > Google Groups "GitLab" group. > To unsubscribe from this topic, visit > https://groups.google.com/d/topic/gitlabhq/IIFsrJo_nV8/unsubscribe. > To unsubscribe from this group and all its topics, send an email to > gitlabhq+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/gitlabhq/CAJTzhG_2ThUypxYDnf1URAF0ObKZ7HevNNLDTFC3EgKuEm6%3DoQ%40mail.gmail.com. > For more options, visit https://groups.google.com/d/optout. > > > > -- > You received this message because you are subscribed to the Google Groups > "GitLab" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to gitlabhq+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/gitlabhq/880C99DE-1362-4E3D-AA98-9F5D256BC027%40gmail.com. > > For more options, visit https://groups.google.com/d/optout. > > > -- > You received this message because you are subscribed to a topic in the > Google Groups "GitLab" group. > To unsubscribe from this topic, visit > https://groups.google.com/d/topic/gitlabhq/IIFsrJo_nV8/unsubscribe. > To unsubscribe from this group and all its topics, send an email to > gitlabhq+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/gitlabhq/CAJTzhG9hmza3bAZM5GNcbfr6mxtY4114vyujmXJNTudufKppCA%40mail.gmail.com. > For more options, visit https://groups.google.com/d/optout. > > > -- > You received this message because you are subscribed to the Google Groups > "GitLab" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to gitlabhq+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/gitlabhq/3F1D6184-78CB-4B79-B94E-24174DC5A2F8%40gmail.com. > > For more options, visit https://groups.google.com/d/optout. -- You received this message because you are subscribed to the Google Groups "GitLab" group. To unsubscribe from this group and stop receiving emails from it, send an email to gitlabhq+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/gitlabhq/CAJTzhG_j0B8qi12Z%2BhjYjuVT6PrDZAuDFRjfr%3DCc0JbP-xijAQ%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
