Hi,

I've found some bugs in the commit view, however I don't know how to fix them 
(due to my bad ruby skills).

./app/views/commits/show.html.erb:
Line 38: 
 * ":aciton" should be ":action"
 * The link_to "Diffs" and link_to "Comments" results in bad links, if the 
commit is applied to a user's repository clone. 

As an example, let's have a look at the commit a9bf0c1da of Christian in 
cjohansens-mainline [1]. The Javascript Diff is shown correctly, however the 
Diff link behind the javascript code results in
  
http://gitorious.org/~cjohansen/cjohansens-mainline/commit/a9bf0c1da26b23e30f97a819f88474ffd5f3b481/diffs

The correct URL should include the project the clone is based on, namely 
"gitorious"
  
http://gitorious.org/~cjohansen/gitorious/cjohansens-mainline/commit/a9bf0c1da26b23e30f97a819f88474ffd5f3b481/diffs

I could trace the error down to the commits_controller.rb, however I don't have 
a clue how to fix these errors, sorry. Perhaps the same happens for the 
diffs_url used in line 30.

Greetings, Thomas


[1] http://gitorious.org/~cjohansen/gitorious/  
/commit/a9bf0c1da26b23e30f97a819f88474ffd5f3b481

-- 
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]

Reply via email to