Em 23-05-2011 10:23, Christian Johansen escreveu:
I'm advancing in the migration to Devise in the temporary branch
(gitorious-3.1-devise-temp). Currently, it is necessary to add
support for OpenID and Basic HTTP authentication.
Good to hear.
Also, I need to figure out what is needed for the SSL enforcing
tests to pass (I've disabled them temporarily for better filtering
the failing tests). But it seems Rails 3.1 may not need the
ssl_requirement plugin since there will be a native helper for that:
https://github.com/rails/rails/blob/master/actionpack/lib/action_controller/metal/force_ssl.rb
This looks like it will cover it, yes. What's the problem with the
tests? As far as I can tell, the ssl requirement macros are still in
the test directory?
I don't know yet why the SSL enforcing tests are failing yet. I was
focused on getting the basic database authentication working. Now, I'm
going to add support for OpenID and Basic HTTP Auth and then I'll take a
look back at the SSL tests.
If you want to try to fix it, just revert the commit below and re-run
the tests:
https://gitorious.org/~rosenfeld/gitorious/rosenfeld-gitorious/commit/9d08868bd3d07a3993cbcb6e2f2ae1dd80bdab5a
<https://gitorious.org/%7Erosenfeld/gitorious/rosenfeld-gitorious/commit/9d08868bd3d07a3993cbcb6e2f2ae1dd80bdab5a>
The commits below can already be cherry-picked into master:
https://gitorious.org/~rosenfeld/gitorious/rosenfeld-gitorious/commit/09a83af280b89e7b076419992bb65dd7d8652953
<https://gitorious.org/%7Erosenfeld/gitorious/rosenfeld-gitorious/commit/09a83af280b89e7b076419992bb65dd7d8652953>
https://gitorious.org/~rosenfeld/gitorious/rosenfeld-gitorious/commit/089d1e277c5c7e938d720e1d7bafa1a183c213ac
<https://gitorious.org/%7Erosenfeld/gitorious/rosenfeld-gitorious/commit/089d1e277c5c7e938d720e1d7bafa1a183c213ac>
https://gitorious.org/~rosenfeld/gitorious/rosenfeld-gitorious/commit/3ab4c77a8179402668b4e6246c8c68c4f4dd9ec2
<https://gitorious.org/%7Erosenfeld/gitorious/rosenfeld-gitorious/commit/3ab4c77a8179402668b4e6246c8c68c4f4dd9ec2>
(won't make any difference now, but it is a good idea)
these ones should be merged in a single commit with a different message:
https://gitorious.org/~rosenfeld/gitorious/rosenfeld-gitorious/commit/7624c65096c63e4b7dd43d6a70fa78028cd043d5
<https://gitorious.org/%7Erosenfeld/gitorious/rosenfeld-gitorious/commit/7624c65096c63e4b7dd43d6a70fa78028cd043d5>
https://gitorious.org/~rosenfeld/gitorious/rosenfeld-gitorious/commit/50f87f6be922fff1531393f8b0fcda0017caafbd
<https://gitorious.org/%7Erosenfeld/gitorious/rosenfeld-gitorious/commit/50f87f6be922fff1531393f8b0fcda0017caafbd>
(only tests under test/functionals)
The current rails-3.1 branch could also be merged with master, since it
has nothing specific to Rails 3.
Well, that is it for now :)
--
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
