Fantastic, thanks Marius.

I was actually just muddling through the codebase myself just now, with the 
view to doing the same.

I'm about to change a good few templates now and try a merge request. I'm 
learning Ruby on the go :)

I'd just found that GitoriousConfig["scheme"] property and was about to use 
it!
The main URLs in the email templates seem perfectly fine now due to your 
change, but the other URLs are a bit hit and miss. I'll go through them now 
to change them. e.g. see app/views/mailer/activation.html.erb compared 
to app/views/mailer/forgotten_password.html.erb

Hopefully I can contribute something back to the project.


Also, I've noticed that in app/helpers/application_helper.rb the following 
is defined:

  def dashboard_path
    root_url(:host => GitoriousConfig["gitorious_host"], :protocol => 
"http")
  end

Shouldn't "http" in that be replaced with GitoriousConfig["scheme"] ?

Cheers,
Shane

-- 
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]

Reply via email to