On Tue, Apr 17, 2012 at 2:32 AM, Marius Mårnes Mathiesen <[email protected]> wrote: > Great work! I know next to nothing about Kerberos, but it's been on my todo > list for a while to investigate how to support it in Gitorious.
Thanks! I appreciate your review and your feedback. I implemented your suggestion for modifying the auth plugin API, and broke that off into my first patch. I tried to update the test suite to match this change. Kerberos auth is in the second patch. It is similar the patch I previously emailed, with the following improvements: - Add a "pretty" HTTP 401 error page to match the rest of Gitorious's look and feel. The web server will show this error if the user's Kerberos credentials are missing or invalid, or if the user's browser is not properly configured for Kerberos authentication. - When auto-registering a user, set the default email address to use the user's original Kerberos principal, rather than the sanitized Gitorious username. - Add a basic set of tests. Both patches are attached, rebased against current master (430eb2bda). Please let me know if these look ok :) - Ken -- To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected]
0001-wrap-authenticate-parameters-in-a-credential-object.patch
Description: Binary data
0002-implement-Kerberos-authentication.patch
Description: Binary data
