Hey, On Mon, Aug 31, 2009 at 7:01 PM, Johannes Gilger<[email protected]> wrote: > > On 31/08/09 08:25, Stonewall Ballard wrote: >> It seems that you all aren't using XCode 3.2. Pieter said that it >> changes the xibs, hence produces excessively-large patches. I think >> I'll have to wait until the origin is updated. Might that happen >> anytime soon? > Yes, I'm hoping Pieter will push to GitHub soon too ;) About XCode 3.2: > I just noticed it is out (though it seems to be targeted at 10.6). I > ordered Snow Leopard yesterday and will start using it next week when I > get back home.
I'm sorry, I forgot to push, I fixed it now :) >> Meanwhile, I've put this patch here: >> <http://dl.getdropbox.com/u/297034/0001-Add-preferences-for-opening- >> things-at-launch.patch.zip> > Now, about the patch: It looks fine, one thing one might argue about is > the wording of the prefs and the placement, but that's something we can > worry about when we get more preference-options. I can't say much about > the XIB, but it probably could be a smaller diff. But it applied fine on > my bugfixes-branch, so no problem here. > > One tiny technical detail I was wondering about was: > id curPath = [[[NSProcessInfo processInfo] environment] objectForKey:@"PWD"]; > This works fine, but shouldn't we use NSString* curPath = ... here? > Using a specific type makes it easier for a reviewer to see what kind of > object is to be expected, and in this case it's clearly a string, last > but not least because [NSURL fileURLWithPath:curPath] expects an > NSString* as parameter. > > Other than that I have no objections to this patch from the > usability-standpoint, I even might come to use it myself ;) I agree with Johannes' comment about NSString *, but I haven't looked into the patch thoroughly yet. I'm still having trouble with my RSI (:(), but I'll see if I have some time tomorrow to look at it. - Pieter
