On 02/09/09 10:22, JD Smith wrote:
> In principle, my patch does not touch the hunk-wise stuff, which was  
> (and is) working in my franken-gitx-version (0.6.3 + my changes to JS/ 
> CSS).  Is this the first test it's had in the trunk?  I consider it  
> likely that the other hunk code drifted in the intervening months, and  
> the patch did not apply cleanly as a result.

Hi JD,

sorry I made such a ruckus. While the stage/unstage-functionality was 
working, you forgot a little change in the discard funtionality (patch 
coming through after this mail).

What's interesting (and that's why I thought that staging/unstaging was 
broken) was that the JavaScript seems to have mangled the context of the 
thing I was trying to stage, which included german umlauts, thereby 
making the patch unusable. We should keep this in mind as a thing we 
might want to fix.

Greetings,
Jojo

(Who already uses your line-wise-patches ;)

P.S.: Dont CC me, I'm on the list! ;)

-- 
Johannes Gilger <[email protected]>
http://heipei.net
GPG-Key: 0x42F6DE81
GPG-Fingerprint: BB49 F967 775E BB52 3A81  882C 58EE B178 42F6 DE81

Reply via email to