On Sep 15, 11:39 am, David James <[email protected]>
wrote:
> I have a few simple changes that hope will do the trick:
>
> 1. Keep the gray lines with "Stage" and "Discard" just the same.
>
> 2. When you mouse over a line where line-by-line staging is allowed,
> show the "Stage line" button. (The current behavior is that a click is
> required to show this button.)
This may not be the best idea... as you mouse over to the "Stage
Lines" button, which may be separated by lots of white space, you may
accidentally move to a new line before hitting it.
> 2A. I would also suggest adding a "Discard line" for completeness, but
> this could be done later.
>
> 3. If you click and drag, gitx should do two things: (1) select the
> text and highlight it just as you would expect in a traditional text
> editor, to facilitate a copy or cut; (2) draw a rectangle with a
> medium-sized border and no interior fill around the selected lines. It
> should also display the "Stage lines" button in an integrated looking
> way so it is clear that clicking "stage lines" would stage the lines,
> not the text selection (which might only be a subset of the lines).
I'm not in love with this either, since then selecting one line is non-
intuitive (drag out some region, even if you don't intend to copy
it). I think holding Option/Alt to select text, as in the simple
patch I provided on the other thread, is workable. Alternatively,
distinguishing the "to be staged" lines in the way indicated here, but
selecting them by click/dragging on the numbers at left also seems
reasonable (though *much* harder to implement).
