On Nov 10, 2:46 pm, Pieter de Bie <[email protected]> wrote:
> I'll reply on this thread, which seems more relevant :)
>
> On Tue, Nov 10, 2009 at 3:38 PM, Jonathan del Strother
>
> <[email protected]> wrote:
>
> >http://groups.google.com/group/gitx/browse_thread/thread/39a7360d5d4a...
> >http://groups.google.com/group/gitx/browse_thread/thread/f8322899f11c...
>
> > Just scratching a personal itch - I wanted to be able to view more of
> > the history than the default font setting would allow, so the two
> > patches above add zoom in-out buttons to the history window's
> > toolbar.
>
> I think adding buttons to the toolbar might be a bit weird, but I'm
> not sure about that. Perhaps just add an edit field / slider in the
> preferences, or two menu items somewhere? I'm not sure, I have 0
> instinct when it comes to stuff like this, but I don't think I've seen
> increase/decrease buttons in a toolbar before :)
>
> Other than that and the default issue the implementation seems clean
> and the feature useful.

How about this -
http://github.com/jdelStrother/gitx/tree/historyZoomTake2
http://groups.google.com/group/gitx/browse_thread/thread/5b4a5f9c39a654e8
http://groups.google.com/group/gitx/browse_thread/thread/ef3a5a5b1c723a5a

This pushes userDefaults handling into PBGitDefaults, and replaces the
toolbar buttons with menu items.  I didn't want to hide them in the
preferences window because I've found it useful to be able to zoom in
& out at will, depending on how focussed a view I want.

Any thoughts?

Reply via email to