On Thu, Mar 18, 2010 at 5:08 PM, Nathan Kinsinger <
[email protected]> wrote:

Actually it was the "Raw View" that was removed. The tree view is the one
> with the file list on the left and the contents on the right.
> <
> http://github.com/pieter/gitx/commit/34394d056b5ff0a4620a79c606f26ff4870c67f3
> >
>

Aha, and so it is. I'll re-do the patch and re-submit it.

The setTreeView: method has the wrong tab number. It would probably be
> better to use constants for the selectedTab so that changes happen
> everywhere.
>

I actually updated the code in my branch to use a single method that checks
the sender's tag. I didn't submit that as part of the patch though.
Something like this:

(IBAction)setDetailView:(id)sender
{
  [self setSelectedTab:[sender tag]];
}

This technique requires us to set the menu tags in IB but it allows us to
funnel everything through one method without having to concern ourselves
with the actual values in the code. It's also future proof in that if the
Raw view returned at some point, the code would continue to work. I'll
include this with the new patch.

Kevin

Reply via email to