Nathan, thank you for reviewing the patch.
The yellow color – well that was just the first thing that came into my mind and seemed to be 'good enough'. Of course, the orange-like color used to mark the current ref would be more consistent: >From c33db44cf895054430447075be9046efc81bc057 Mon Sep 17 00:00:00 2001 From: ngu <[email protected]> Date: Sun, 11 Apr 2010 14:40:07 +0300 Subject: [PATCH] Yellow->orange --- PBGitRevisionCell.m | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/PBGitRevisionCell.m b/PBGitRevisionCell.m index 688358d..2c6ccb6 100644 --- a/PBGitRevisionCell.m +++ b/PBGitRevisionCell.m @@ -83,7 +83,7 @@ - (void) drawCircleInRect: (NSRect) r NSRect smallOval = { columnOrigin.x - 3, columnOrigin.y + r.size.height * 0.5 - 3, 6, 6}; if ( [self isCurrentCommit ] ) { - [[NSColor yellowColor] set]; + [[NSColor colorWithCalibratedRed: 0Xfc/256.0 green:0Xa6/256.0 blue: 0X4f/256.0 alpha: 1.0] set]; } else { [[NSColor whiteColor] set]; } -- 1.7.0.2 On Apr 11, 2:46 am, Nathan Kinsinger <[email protected]> wrote: > On Apr 10, 2010, at 12:23 PM, Mykola Gurov wrote: > > > Hi Mykola, > > Code wise this looks good to me, thanks for sending it. I do wonder about > using yellow though. The checked out ref is orange, it might be better to > make it the same. > > After I'm done being distracted by my iPad I'll get back to GitX and put this > in my experimental branch in the next update. > > --Nathan > > http://brotherbard.com/ -- To unsubscribe, reply using "remove me" as the subject.
