I removed the glade_widget_class_new_from_name, but I've not yet touched
this one, so you can just commit.

Keep the good work!

Cheers,

> -----Message d'origine-----
> De : [EMAIL PROTECTED] 
> [mailto:[EMAIL PROTECTED] De la part de 
> Archit Baweja
> Envoy� : lundi 25 ao�t 2003 23:01
> � : Paolo Borelli
> Cc : [EMAIL PROTECTED]
> Objet : Re: [Glade-devel] One-liner fix.
> 
> 
> I think I'll wait for Joaquin to commit his catalog rework 
> patches. This seems part of his patch.
> 
> Archit Baweja
> 
> Paolo Borelli <[EMAIL PROTECTED]> writes:
> 
> > On Mon, 2003-08-25 at 10:32, Archit Baweja wrote:
> > > Hi
> > > 
> > > Following is a one liner fix. A thing to note is that 
> both functions 
> > > glade_widget_class_get_by_name (), and 
> > > glade_widget_class_get_from_name () are supposed to do the same 
> > > thing (atleast I think so). They why do we have 2 of 
> them? We should 
> > > remove the old/not-used anymoreone if possible.
> > 
> > Seems right to me and while at it you should also do the same in 
> > main.c (as a matter of fact glade-3 --dump GtkWindow 
> doesn't work at 
> > the
> > moment)
> > 
> > On the other hand, even if I'm not a native english speaker, I like 
> > the name *_get_by_name more: I took a look with a couple of quick 
> > greps and in my opinion you can go all the way, remove the current 
> > glade_widget_get_by_name and rename glade_widget_get_from_name.
> > 
> > ciao
> >     paolo
> > 
> > _______________________________________________
> > Glade-devel maillist  -  [EMAIL PROTECTED] 
> > http://lists.ximian.com/mailman/listinfo/glade-devel
> _______________________________________________
> Glade-devel maillist  -  [EMAIL PROTECTED] 
> http://lists.ximian.com/mailman/listinfo/glade> -devel
> 
> 


_______________________________________________
Glade-devel maillist  -  [EMAIL PROTECTED]
http://lists.ximian.com/mailman/listinfo/glade-devel

Reply via email to