Hey On Sat, 2004-12-18 at 22:16 -0500, Tristan Van Berkom wrote: > Hi, > GtkComboBox IMO is a good idea (it will save the user significant screen > realestate), we might want to converge to a glade-2 style palette for the > same reason. Code-cleanup is also welcome ofcourse (there is still much > cleanup to be done). >
Well ok. But we should really make up our mind about this, because initially glade-3 did have a glade-2/gimp like palette. So switching back and forth isn't a good idea. Also while we are on the subject, personally I prefer the newer arrangement list style as compared to the old MxN matrix. Most other UI Designers use a list stlye. Thats why we switched in the first place. This thread has a history of the last discussion on the subject... http://lists.ximian.com/archives/public/glade-devel/2004-February/000520.html > About using the GladeCommand interface inside the generic Query > popup, > yes that is definitly a bug but I think the "from_query_dialog" code > should > stay in glade-editor.c, if there is not need for an undo; then we > should > skip the middle-man and jump directly to glade_property_set(). Well I see the GladeCommand code first as code for doing "actions" and the undo/redo as a additional feature. Point being I think doing it the "from_query_dialog" way, is the best way. If we do it like you suggest, we'll be copying lots of code from GladeEditor and GladeCommand, only to put it separately as a GladeQueryDialog. Most of the code is already written (thats why glade_editor_query_dialog() in its present form uses the glade_editor_table_create() and friends anyway). We only skip pushing the action on the undo stack. > Finally, please send patches to bugzilla; I find it alot easier to > track that way (nothing gets lost that way and I can always identify > which is the latest version of your patch). Will do. Archit _______________________________________________ Glade-devel maillist - [EMAIL PROTECTED] http://lists.ximian.com/mailman/listinfo/glade-devel
