On Mon, 2005-06-13 at 11:26 -0400, Tristan Van Berkom wrote:
> Hmmm,
> I think the best thing to do for GKeyFile saving is to follow
> whats been done in glade-parser.c, for portability; I think that
> we should:
>
> - Move the `#ifdef _MSC_VER' and `#ifdef G_OS_WIN32' defines
> from glade-parser.c to glade-utils.c
>
> - Expose `write_buffer_contents ()' as `glade_util_write_buffer ()'
> in glade-utils.[ch] (i.e. Move write_buffer_contents &
> write_buffer_contents_stdio from glade-parser.c to glade-utils.c).
Yes, I knew I had to review it for portability but I want to finnish
project window stuff first.
What about using GIOChannel?
> I think that something should be done also for your mkdir, instinct
> tells me that it should be the same as with open/fdopen (i.e.
> if _MSC_VER then #define to `_mkdir' and wrap it with a function
> in glade-utils.c).
I agree, maybe g_mkdir works but I will have to check it.
One question, on windows glade has to compile using MinGW, MSVC++ or
both?
> As for the UIManager code, I struggled a but with the old item factory
> stuff, trying to get the project selection menu to display as radio
> items (showing which project is currently selected), can you, did you
> get that to work properly using the UIManager ?
Yes, it is working because of gpw_select_project_menu() but I plan to
change that adding a new action group for projects and using a
GtkRadioAction instead a GtkToggleAction.
[...]
> Personally I'd like to stay away from using "dispose" methods, we
> currently dont have any complicated situations with circular references
> (hence the need for a complicated two-step object destruction process),
> so if we can get away with just freeing all our resources in finalize
> methods, the code will stay simpler.
well I didn't know the difference of "dispose" and "finalize" methods :D
It is I just can't find a place where to freed the recent_projects
Queue.
glade_project_window_class_init() has "finalize" method commented :(
greets
Juan pablo
___________________________________
A tu celular ¿no le falta algo?
Usá Yahoo! Messenger y Correo Yahoo! en tu teléfono celular.
Más información en http://movil.yahoo.com.ar
_______________________________________________
Glade-devel maillist - Glade-devel@lists.ximian.com
http://lists.ximian.com/mailman/listinfo/glade-devel
