#3772: Methods not inlined
---------------------------------------------+------------------------------
Reporter: rl | Owner:
Type: bug | Status: closed
Priority: normal | Milestone: 6.12 branch
Component: Compiler | Version: 6.12.1
Resolution: fixed | Keywords:
Difficulty: | Os: Unknown/Multiple
Testcase: simplCore/should_compile/T3772 | Architecture: Unknown/Multiple
Failure: Runtime performance bug |
---------------------------------------------+------------------------------
Changes (by simonpj):
* status: new => closed
* testcase: => simplCore/should_compile/T3772
* resolution: => fixed
Comment:
Actually I fixed this one but forgot to update Trac:
{{{
Tue Jan 5 10:16:00 GMT 2010 [email protected]
* Undo the fix for Trac #3772 and do it a new way
The main idea is that I'm now treating a single-method dictionary very
much like a multi-method dictionary. In particular, it respond to
exprIsConApp_maybe, even though newtypes aren't *really* proper
constructors.
See long comments with Note [Single-method classes] for why
this slight hack is justified.
M ./compiler/basicTypes/MkId.lhs -8 +4
M ./compiler/typecheck/TcInstDcls.lhs -25 +67
Mon Dec 21 16:04:31 GMT 2009 [email protected]
* Fix Trac #3772: dict funs for single-field classes
This patch fixes a bug that meant that INLINE pragamas on
a method of a single-field class didn't work properly.
See Note [Single-method classes] in TcInstDcls, and Trac #3772
M ./compiler/typecheck/TcInstDcls.lhs -34 +61
}}}
There's a test in the regression suite. Do not attempt to merge to 6.12;
the code base is very different in this respect.
Simon
--
Ticket URL: <http://hackage.haskell.org/trac/ghc/ticket/3772#comment:3>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler
_______________________________________________
Glasgow-haskell-bugs mailing list
[email protected]
http://www.haskell.org/mailman/listinfo/glasgow-haskell-bugs
