#3899: -ddump-splices missing parentheses in pattern
---------------------------------+------------------------------------------
Reporter: guest | Owner: igloo
Type: merge | Status: new
Priority: normal | Milestone:
Component: Template Haskell | Version: 6.12.1
Keywords: | Difficulty:
Os: Unknown/Multiple | Testcase: th/T3899
Architecture: Unknown/Multiple | Failure: None/Unknown
---------------------------------+------------------------------------------
Changes (by simonpj):
* owner: => igloo
* testcase: => th/T3899
* type: bug => merge
Comment:
Good point. Fixed by
{{{
Thu Mar 4 13:28:26 GMT 2010 [email protected]
* Add parens in patterns; fix Trac #3899
M ./Language/Haskell/TH/Ppr.hs -5 +5
}}}
However in order to add a test I had to make `-dsuppress-uniques` work
better
{{{
Thu Mar 4 12:38:22 GMT 2010 [email protected]
* Two things to do with -dsuppress-uniques
a) Even with -dsuppress-uniques, don't suppress them when outputing
code, else the assembler falls over bleating
b) Do suppress uniques in names generated by TH. It's a bit grungy
to do this: see Note [Suppressing uniques in OccNames]. But
it's only needed for test de-wobblification so the grunge isn't
really important.
M ./compiler/basicTypes/OccName.lhs -4 +19
M ./compiler/basicTypes/Unique.lhs -4 +4
}}}
The fix is worth merging to 6.12. Not sure about the suppress-uniques bit.
Yes, probably.
Simon
--
Ticket URL: <http://hackage.haskell.org/trac/ghc/ticket/3899#comment:1>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler
_______________________________________________
Glasgow-haskell-bugs mailing list
[email protected]
http://www.haskell.org/mailman/listinfo/glasgow-haskell-bugs
