#4184: Squirrelly inliner behaviour leads to 80x slowdown
--------------------------------------+-------------------------------------
  Reporter:  bos                      |          Owner:                  
      Type:  bug                      |         Status:  closed          
  Priority:  normal                   |      Milestone:  7.2.1           
 Component:  Compiler                 |        Version:  6.12.1          
Resolution:  invalid                  |       Keywords:                  
  Testcase:                           |      Blockedby:                  
Difficulty:                           |             Os:  Unknown/Multiple
  Blocking:                           |   Architecture:  Unknown/Multiple
   Failure:  Runtime performance bug  |  
--------------------------------------+-------------------------------------
Changes (by simonpj):

  * status:  new => closed
  * resolution:  => invalid


Comment:

 OK I looked at this.  After an hour I realised that you have written
 {{{
 {- INLINE uniform #-}
 }}}
 rather than
 {{{
 {-# INLINE uniform #-}
 }}}
 so your alleged INLINE pragma is being ignored as a comment.  As Roman
 says, this kills your performance.

 Incidentally, you don't need that weird f any more, if you ever did. It's
 enough to say
 {{{
     uniform = uniform2 wordsToDouble
     {-# INLINE uniform #-}
 }}}
 So I'll close this.  But please re-open if it doesn't work.

 It's unfortunate that a mis-typed pragma just looks like a comment!

 Oh, take note of #4310, which describes a workaround to package `vector`
 that will be needed for a while.

 Simon

-- 
Ticket URL: <http://hackage.haskell.org/trac/ghc/ticket/4184#comment:8>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler
_______________________________________________
Glasgow-haskell-bugs mailing list
[email protected]
http://www.haskell.org/mailman/listinfo/glasgow-haskell-bugs

Reply via email to