#4342: Review containers changes
----------------------------------+-----------------------------------------
Reporter: igloo | Owner:
Type: bug | Status: new
Priority: high | Milestone: 7.2.1
Component: libraries (other) | Version: 7.1
Keywords: | Testcase:
Blockedby: | Difficulty:
Os: Unknown/Multiple | Blocking:
Architecture: Unknown/Multiple | Failure: None/Unknown
----------------------------------+-----------------------------------------
Comment(by milan):
Replying to [comment:14 igloo]:
> Replying to [comment:13 milan]:
> > >
> > > We need it to be `-Wall` clean before we can apply it, though.
> >
> > Do you want me to correct it?
>
> That'd be great, thanks!
>
> > > I would prefer `STRICT_1_OF_2`, but personally I think we should
just use bang patterns.
> >
> > Bang patterns are not in any standards, so this would rule out other
compilers not supporting them. Your rename seems reasonable, I would go
with that.
>
> That's true. Renaming is fine with me.
>
> > > I am suspicious about the extra
> > > clause in `member`, as compared to `lookup`.
> >
> > It is semantically correct both ways.
>
> OK, great, no problem then.
Tomorrow I will prepare updated patches. Simon also pointed that I should
add several my comments from this ticket to the source comments, so people
would know why.
Cheers,
Milan
--
Ticket URL: <http://hackage.haskell.org/trac/ghc/ticket/4342#comment:15>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler
_______________________________________________
Glasgow-haskell-bugs mailing list
[email protected]
http://www.haskell.org/mailman/listinfo/glasgow-haskell-bugs
