#4928: Add primops for copying/cloning an array
------------------------------+---------------------------------------------
  Reporter:  tibbe            |          Owner:  simonmar        
      Type:  feature request  |         Status:  patch           
  Priority:  normal           |      Milestone:                  
 Component:  Runtime System   |        Version:  7.0.1           
Resolution:                   |       Keywords:                  
  Testcase:                   |      Blockedby:                  
Difficulty:                   |             Os:  Unknown/Multiple
  Blocking:                   |   Architecture:  Unknown/Multiple
   Failure:  None/Unknown     |  
------------------------------+---------------------------------------------

Comment(by simonmar):

 On the whole, the patch looks good (especially if you squash it into one
 patch, which I'll do before pushing unless you do).  I think there might
 still be some problems in the implementation though:

 {{{
 +    I8[dst_cards_start + mutArrPtrsCardWords(n)] = I8[dst_cards_start +
 mutArrPtrsCardWords(dst_start + n)] | I8[src_cards_start +
 mutArrPtrsCardWords(src_start + n)]; \
 }}}

 this can't be right, because all offsets in Cmm are in bytes, and you're
 adding a word index (`mutArrPtrsCardWords(n)`).

-- 
Ticket URL: <http://hackage.haskell.org/trac/ghc/ticket/4928#comment:11>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler

_______________________________________________
Glasgow-haskell-bugs mailing list
[email protected]
http://www.haskell.org/mailman/listinfo/glasgow-haskell-bugs

Reply via email to