#3994: Add support for creating and interrupting process groups
----------------------------------+-----------------------------------------
    Reporter:  hamish             |        Owner:  simonmar    
        Type:  feature request    |       Status:  patch       
    Priority:  high               |    Milestone:  7.2.1       
   Component:  libraries/process  |      Version:  6.12.1      
    Keywords:                     |     Testcase:              
   Blockedby:                     |   Difficulty:              
          Os:  Unknown/Multiple   |     Blocking:              
Architecture:  Unknown/Multiple   |      Failure:  None/Unknown
----------------------------------+-----------------------------------------

Comment(by simonmar):

 Replying to [comment:15 hamish]:
 > I tried GetProcessId again and it works.  Not sure what happened when I
 tried it before, but I think I might have messed up the calling convention
 by not defining _WINNT_VER before including windows.h (I noticed this time
 when I was testing GetProcessId in runProcess.c that I got a warning that
 it was GetProcessId's sig was not defined if I did not define _WINNT_VER).
 >
 > Anyway I stuck getProcessId into Win32 package where it belongs and it
 works fine.
 >
 > I have updated the patch with this and your other suggestions and the
 new version is here
 > https://github.com/hamishmack/packages-
 process/tree/Ticket-3994-GetProcessId
 > and
 > https://github.com/hamishmack/packages-
 Win32/tree/Ticket-3994-GetProcessId
 >
 > I also added a test case that makes sure "sleep 10" can be interrupted.
 >
 > The flags are in a separate header so they can easily be #included in
 both the .hs and the .c (runProcess.h did not work when #included in the
 .hs)

 I took a quick look, and the changes look fine - much easier to review
 this version without the changes to `ProcessHandle`.  When you've reached
 a fixed point with the patch I'll push it in.

-- 
Ticket URL: <http://hackage.haskell.org/trac/ghc/ticket/3994#comment:17>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler

_______________________________________________
Glasgow-haskell-bugs mailing list
[email protected]
http://www.haskell.org/mailman/listinfo/glasgow-haskell-bugs

Reply via email to