Today's HEAD produced 49 unexpected failures, most of which are caused by trivia.
- tcrun006 and tcrun029 use datatype contexts which were removed from HEAD (7 ways each), can be fixed by adding a language pragma (cf. also http://hackage.haskell.org/trac/ghc/ticket/5229) - ghcpk01.stdout hasn't yet been updated to include the new trusted field - ffi005 fails to compile (7 ways) due to an ambiguous occurrence of unsafePerformIO (Foreign and System.IO.Unsafe) - cg005 and T4059 have unexpected stderr due to a warning about unsafePerformIO going to be removed from Foreign - T4437 fails to compile due to a type change: T4437.hs:9:39: Couldn't match expected type `(String, CmdLineParser.FlagSafety, ExtensionFlag, DynFlags.TurnOnFlag -> DynFlags.DynP ())' with actual type `(t0, t1, t2)' In the pattern: (ext, _, _) In a stmt of a list comprehension: (ext, _, _) <- xFlags In the expression: [ext | (ext, _, _) <- xFlags] Those are easily fixed by the attached patches (but some may need a more principled fix). Further, 17 unexpected failures are due to hpc output being formatted differently from the expectation (5x hpc_fork, 6x hpc001, 6x tough). Two unexpected failures (T4809, cgrun068) are due to mtl not being built the dyn way. The remaining 5 are - T4801 (allocating too little because there are fewer Generic instances for tuples) - dph-diophantine-opt (3 ways) - dph-words-opt On my 32-bit box, also T3294 unexpectedly fails since about a week ago due to too little allocation (a bit below 690M, minimum allowed 800M). If that's reproducible and not known to be temporary, the bounds should be adjusted. Cheers, Daniel
From 92dbf9a5b4516d27fc0d389f842e21b4d3df5e5e Mon Sep 17 00:00:00 2001 From: Daniel Fischer <[email protected]> Date: Tue, 21 Jun 2011 14:32:13 +0200 Subject: [PATCH 1/7] DatatypeContexts for tcrun006 --- tests/ghc-regress/typecheck/should_run/tcrun006.hs | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/ghc-regress/typecheck/should_run/tcrun006.hs b/tests/ghc-regress/typecheck/should_run/tcrun006.hs index c55ef88..4c84331 100644 --- a/tests/ghc-regress/typecheck/should_run/tcrun006.hs +++ b/tests/ghc-regress/typecheck/should_run/tcrun006.hs @@ -1,3 +1,4 @@ +{-# LANGUAGE DatatypeContexts #-} -- !!! Selectors for data and newtypes with contexts -- This program, reported in Aug'00 by Jose Emilio Labra Gayo @@ -8,8 +9,8 @@ module Main where -newtype (Eq f) => NewT f = NewIn { newout :: f } -data (Eq f) => DataT f = DataIn { dataout :: f } +newtype (Eq f) => NewT f = NewIn { newout :: f } +data (Eq f) => DataT f = DataIn { dataout :: f } main = print (newout (NewIn "ok new") ++ dataout (DataIn " ok data")) -- 1.7.3.4
From 890b8504052a7debcca0a221db0d4543a328004f Mon Sep 17 00:00:00 2001 From: Daniel Fischer <[email protected]> Date: Tue, 21 Jun 2011 14:33:15 +0200 Subject: [PATCH 2/7] DatatypeContexts for tcrun029 --- tests/ghc-regress/typecheck/should_run/tcrun029.hs | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/ghc-regress/typecheck/should_run/tcrun029.hs b/tests/ghc-regress/typecheck/should_run/tcrun029.hs index 53c67e5..f25a401 100644 --- a/tests/ghc-regress/typecheck/should_run/tcrun029.hs +++ b/tests/ghc-regress/typecheck/should_run/tcrun029.hs @@ -1,3 +1,4 @@ +{-# LANGUAGE DatatypeContexts #-} -- Killed GHC 5.02.3 -- Confusion about whether the wrapper for a data constructor @@ -6,11 +7,11 @@ module Main where -data Color = Red +data Color = Red | Black deriving Show -data Ord k => Tree k d = None +data Ord k => Tree k d = None | Node{color::Color, key::k, item::d, -- 1.7.3.4
From a5ed55598fa0044e1f548dbe09cd8811f7ba796e Mon Sep 17 00:00:00 2001 From: Daniel Fischer <[email protected]> Date: Tue, 21 Jun 2011 14:34:56 +0200 Subject: [PATCH 3/7] Use System.IO.unsafePerformIO in ffi005 --- tests/ghc-regress/ffi/should_run/ffi005.hs | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/ghc-regress/ffi/should_run/ffi005.hs b/tests/ghc-regress/ffi/should_run/ffi005.hs index 1496922..12b71ba 100644 --- a/tests/ghc-regress/ffi/should_run/ffi005.hs +++ b/tests/ghc-regress/ffi/should_run/ffi005.hs @@ -4,7 +4,7 @@ import Foreign import Foreign.C import Control.Exception -import System.IO.Unsafe +import System.IO.Unsafe as U import Prelude hiding (read) import System.IO (hFlush, stdout) @@ -40,7 +40,7 @@ main = do putStrLn "\nTesting sin==IO wrapped_sin (should return lots of Trues)" sin_addr2 <- wrapIO (return . sin) - print (testSin sin (unsafePerformIO . (dyn_sinIO sin_addr2))) + print (testSin sin (U.unsafePerformIO . (dyn_sinIO sin_addr2))) freeHaskellFunPtr sin_addr2 putStrLn "\nTesting sin==Id wrapped_sin (should return lots of Trues)" @@ -108,4 +108,4 @@ foreign import ccall exit :: Int -> IO () -- foreign import ccall safe "dynamic" illegal_baz :: FunCString -> Char -- foreign export ccall "id_charstar" id :: CString -> CString - + -- 1.7.3.4
From c0e74f49733104fb17a34a39f1d575951ffafd16 Mon Sep 17 00:00:00 2001 From: Daniel Fischer <[email protected]> Date: Tue, 21 Jun 2011 14:40:44 +0200 Subject: [PATCH 7/7] Adjust to new type of xFlags in T4437 --- tests/ghc-regress/driver/T4437.hs | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tests/ghc-regress/driver/T4437.hs b/tests/ghc-regress/driver/T4437.hs index a348e47..53234bc 100644 --- a/tests/ghc-regress/driver/T4437.hs +++ b/tests/ghc-regress/driver/T4437.hs @@ -6,7 +6,7 @@ import DynFlags import Language.Haskell.Extension main :: IO () -main = do let ghcExtensions = [ ext | (ext, _, _) <- xFlags ] +main = do let ghcExtensions = [ ext | (ext, _, _, _) <- xFlags ] cabalExtensions = map show [ toEnum 0 :: KnownExtension .. ] ghcOnlyExtensions = ghcExtensions \\ cabalExtensions -- These are extensions which are deliberately not yet -- 1.7.3.4
From 189429e0cd6760b668341139a87800cb360070a0 Mon Sep 17 00:00:00 2001 From: Daniel Fischer <[email protected]> Date: Tue, 21 Jun 2011 14:37:10 +0200 Subject: [PATCH 4/7] Add trusted to ghcpkg01.stdout --- tests/ghc-regress/cabal/ghcpkg01.stdout | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/tests/ghc-regress/cabal/ghcpkg01.stdout b/tests/ghc-regress/cabal/ghcpkg01.stdout index edfa92d..fb3ecdf 100644 --- a/tests/ghc-regress/cabal/ghcpkg01.stdout +++ b/tests/ghc-regress/cabal/ghcpkg01.stdout @@ -17,6 +17,7 @@ author: [email protected] exposed: True exposed-modules: A hidden-modules: B C.D +trusted: False import-dirs: /usr/local/lib/testpkg "c:/Program Files/testpkg" library-dirs: /usr/local/lib/testpkg "c:/Program Files/testpkg" hs-libraries: testpkg-1.2.3.4 @@ -50,6 +51,7 @@ author: [email protected] exposed: True exposed-modules: A hidden-modules: B C.D +trusted: False import-dirs: /usr/local/lib/testpkg "c:/Program Files/testpkg" library-dirs: /usr/local/lib/testpkg "c:/Program Files/testpkg" hs-libraries: testpkg-1.2.3.4 @@ -89,6 +91,7 @@ author: [email protected] exposed: False exposed-modules: A hidden-modules: B C.D C.E +trusted: False import-dirs: /usr/local/lib/testpkg "c:/Program Files/testpkg" library-dirs: /usr/local/lib/testpkg "c:/Program Files/testpkg" hs-libraries: testpkg-2.0 @@ -122,6 +125,7 @@ author: [email protected] exposed: False exposed-modules: A hidden-modules: B C.D C.E +trusted: False import-dirs: /usr/local/lib/testpkg "c:/Program Files/testpkg" library-dirs: /usr/local/lib/testpkg "c:/Program Files/testpkg" hs-libraries: testpkg-2.0 @@ -155,6 +159,7 @@ author: [email protected] exposed: True exposed-modules: A hidden-modules: B C.D +trusted: False import-dirs: /usr/local/lib/testpkg "c:/Program Files/testpkg" library-dirs: /usr/local/lib/testpkg "c:/Program Files/testpkg" hs-libraries: testpkg-1.2.3.4 @@ -195,6 +200,7 @@ author: [email protected] exposed: False exposed-modules: A hidden-modules: B C.D +trusted: False import-dirs: /usr/local/lib/testpkg "c:/Program Files/testpkg" library-dirs: /usr/local/lib/testpkg "c:/Program Files/testpkg" hs-libraries: testpkg-1.2.3.4 -- 1.7.3.4
From da32e58b4a827ddcd28e4875885e5e26d46ebd55 Mon Sep 17 00:00:00 2001 From: Daniel Fischer <[email protected]> Date: Tue, 21 Jun 2011 14:38:07 +0200 Subject: [PATCH 5/7] Use System.IO.unsafePerformIO in cg005 --- tests/ghc-regress/codeGen/should_compile/cg005.hs | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/tests/ghc-regress/codeGen/should_compile/cg005.hs b/tests/ghc-regress/codeGen/should_compile/cg005.hs index 4cfab59..26099c7 100644 --- a/tests/ghc-regress/codeGen/should_compile/cg005.hs +++ b/tests/ghc-regress/codeGen/should_compile/cg005.hs @@ -3,12 +3,13 @@ module Bug where import Foreign import Foreign.ForeignPtr import Data.Char +import System.IO.Unsafe as U data PackedString = PS !(ForeignPtr Word8) !Int !Int (!) :: PackedString -> Int -> Word8 (PS x s _l) ! i - = unsafePerformIO $ withForeignPtr x $ \p -> peekElemOff p (s+i) + = U.unsafePerformIO $ withForeignPtr x $ \p -> peekElemOff p (s+i) w2c :: Word8 -> Char w2c = chr . fromIntegral -- 1.7.3.4
From 99e3a3018cc31055354e6660cfb099219096496d Mon Sep 17 00:00:00 2001 From: Daniel Fischer <[email protected]> Date: Tue, 21 Jun 2011 14:39:44 +0200 Subject: [PATCH 6/7] Use System.IO.unsafePerformIO in 4059 --- tests/ghc-regress/rts/4059.hs | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/tests/ghc-regress/rts/4059.hs b/tests/ghc-regress/rts/4059.hs index 699dd11..aa94eca 100644 --- a/tests/ghc-regress/rts/4059.hs +++ b/tests/ghc-regress/rts/4059.hs @@ -3,8 +3,9 @@ import Foreign import Foreign.C +import System.IO.Unsafe as U -d f x = unsafePerformIO $ do +d f x = U.unsafePerformIO $ do g <- mkfun f r <- deriv g x 1 return r -- 1.7.3.4
_______________________________________________ Glasgow-haskell-users mailing list [email protected] http://www.haskell.org/mailman/listinfo/glasgow-haskell-users
