On Monday 02 April 2007 00:12:36 Kai Antweiler wrote: > Hi, > > Considering the mail from Shawn about his compiler having problems > with some of our code, I have tried to get our code to work with > flags -wall -pedantic . But I couldn't get gcc to complain about > the functions that Shawns compiler had trouble with. > > I spend hours doing changes like removing "," from the last > enum elements and removing ";" from the closing "}" of namespaces. > Or putting in type conversions between int and unsinged. > > But I added some missing return statements and a lot of type > conversions too. > > > So question is shall I upload this to cvs? > I would say yes. But if some of you prefer using commas > or semicolons in these places I leave everything the way it > is in cvs now. And try to find the missing return types and > most serious type conversions again.
I agree for missing return values and types conversions, but "," in last elements of enum are convenient when copy-pasting. Anyway I do not say you should undo your work (ok to upload it to cvs) but we should not state a coding rule to prohibit them either. Steph -- http://nct.ysagoon.com _______________________________________________ glob2-devel mailing list [email protected] http://lists.nongnu.org/mailman/listinfo/glob2-devel
