>It is something we should fix. If there is an update of the .spec
needed, a correction like this can get included. Otherwise just follow
the normal process for a bugfix (file a bug, post a patch).
>

Yep, this is fixed in master (http://review.gluster.org/#/c/8116/) .
We have to include it in 3.6 branch. May be with logrotate spec file patch?

--Humble

--Humble
http://humblec.com

On Wed, Oct 29, 2014 at 1:22 AM, Niels de Vos <nde...@redhat.com> wrote:

> On Wed, Oct 29, 2014 at 01:01:28AM +0530, Lalatendu Mohanty wrote:
> > On 10/28/2014 11:32 PM, Anders Blomdell wrote:
> > >Does the following warning:
> > >   warning: bogus date in %changelog: Thu Jun 29 2014 Humble Chirammal <
> hchir...@redhat.com>
> > >warrant a bug report/fix as below (based on date of commit 8d8abc19)?
> Or should I just leave it as is?
> > >
> > >
> > >diff --git a/glusterfs.spec.in b/glusterfs.spec.in
> > >index f373b45..5ad4956 100644
> > >--- a/glusterfs.spec.in
> > >+++ b/glusterfs.spec.in
> > >@@ -1042,7 +1042,7 @@ fi
> > >  * Wed Sep 24 2014 Balamurugan Arumugam <barum...@redhat.com>
> > >  - remove /sbin/ldconfig as interpreter (#1145992)
> > >-* Thu Jun 29 2014 Humble Chirammal <hchir...@redhat.com>
> > >+* Thu Jun 19 2014 Humble Chirammal <hchir...@redhat.com>
> > >  - Added dynamic loading of fuse module with glusterfs-fuse package
> installation in el5.
> > >  * Fri Jun 27 2014 Kaleb S. KEITHLEY <kkeit...@redhat.com>
> > >
> > >
> > >/Anders
> > I checked master branch and I can see the date and day is correct in
> > glusterfs.spec.in as below. Where do you see wrong change log i.e. Thu
> Jun
> > 29 2014 Humble Chirammal <hchir...@redhat.com>?
> >
> > * Thu Jun 19 2014 Humble Chirammal <hchir...@redhat.com>
> > - Added dynamic loading of fuse module with glusterfs-fuse package
> > installation in el5.
>
> That seems to come from commit 8d8abc19 in release-3.6:
>
> commit 8d8abc19b0500b725f92164c096b64b3c37cd6b0
> Author: Humble Chirammal <hchir...@redhat.com>
> Date:   Thu Jun 19 16:51:57 2014 +0530
>
>     Autoload fuse module in centos5/el5 versions.
>
>     This patch dynamically load 'fuse' module with the installation
>     of glusterfs-fuse package in centos/el5 distributions.
>
>     Change-Id: I4988a025bd18716fd6d355431196540e140224b3
>     BUG: 1108669
>     Signed-off-by: Humble Chirammal <hchir...@redhat.com>
>     Reviewed-on: http://review.gluster.org/8116
>     Reviewed-by: Niels de Vos <nde...@redhat.com>
>     Reviewed-by: Lalatendu Mohanty <lmoha...@redhat.com>
>     Tested-by: Gluster Build System <jenk...@build.gluster.com>
>
>
> It is something we should fix. If there is an update of the .spec
> needed, a correction like this can get included. Otherwise just follow
> the normal process for a bugfix (file a bug, post a patch).
>
> Thanks,
> Niels
> _______________________________________________
> Gluster-devel mailing list
> Gluster-devel@gluster.org
> http://supercolony.gluster.org/mailman/listinfo/gluster-devel
>
_______________________________________________
Gluster-devel mailing list
Gluster-devel@gluster.org
http://supercolony.gluster.org/mailman/listinfo/gluster-devel

Reply via email to