----- Original Message ----- > From: "Emmanuel Dreyfus" <[email protected]> > To: "Niels de Vos" <[email protected]> > Cc: [email protected], [email protected] > Sent: Sunday, January 17, 2016 10:23:16 AM > Subject: Re: [Gluster-devel] [Gluster-infra] NetBSD regression fixes > > Niels de Vos <[email protected]> wrote: > > > > 2) Spurious failures > > > I added a retry-failed-test-once feature so that we get less regression > > > failures because of spurious failures. It is not used right now because > > > it does not play nicely with bad tests blacklist. > > > > > > This will be fixed by that changes: > > > http://review.gluster.org/13245 > > > http://review.gluster.org/13247 > > > > > > I have been looping failure-free regression for a while with that trick. > > > > Nice, thanks for these improvements! > > But I just realized the change is wrong, since running tests "new way" > stops on first failed test. My change just retry the failed test and > considers the regression run to be good on success, without running next > tests. > > I will post an update shortly. >
I think we should not take this approach. If the tests are not reliable then there is no guarantee that it will pass in the next retry. In fact we should not rely on luck here. Lets not run those tests which are spurious in nature. Anyway we don't consider the result of those tests. Therefore I think we should consider the patch sent by Talur (http://review.gluster.org/13173). > > Could you send a pull request for the regression.sh script on > > https://github.com/gluster/glusterfs-patch-acceptance-tests/ ? Or, if > > you dont use GitHub, send the patch by email and we'll take care of > > pushing it for you. > > Sure, but let me settle on something that works first. > > -- > Emmanuel Dreyfus > http://hcpnet.free.fr/pubz > [email protected] > _______________________________________________ > Gluster-devel mailing list > [email protected] > http://www.gluster.org/mailman/listinfo/gluster-devel > _______________________________________________ Gluster-devel mailing list [email protected] http://www.gluster.org/mailman/listinfo/gluster-devel
