Hi, This is what happens when glfs_set_xlator_option is called: - It updates ctx->cmd_args->xlator_options - gf_add_cmdline_options (during glusterfs_graph_prepare.. pub_glfs_init) adds it to xl->options - glusterfs_graph_unknown_options (during glusterfs_graph_activate.. pub_glfs_init) checks if the options in xl->options are present or not. If the option is not present it just logs a warning message. These options are treated as command line args.
To report the option as a failure, at the least we can fail glfs_init() Regards, Poornima ----- Original Message ----- > From: "Raghavendra Gowdappa" <[email protected]> > To: "Poornima Gurusiddaiah" <[email protected]>, "Raghavendra Talur" > <[email protected]> > Cc: "Gluster Devel" <[email protected]>, "Jeff Cody" > <[email protected]>, "Rajesh Joseph" <[email protected]> > Sent: Monday, May 9, 2016 8:45:56 AM > Subject: xlator option setting in gfapi > > Hi Poornima/Raghavendra, > > This mail is an initiation of a thread to discuss how to make xlator options > setting in gfapi synchronous (so, that caller will know the result) or > providing a cbk to let the application know about the status. > > My very naive attempt of code-reading showed me that > pub_glfs_set_xlator_option just adds the option to cmd_args.xlator_options. > Can you please explain how/when these values are communicated to glusterd to > change volfile? From there we can carry forward the conversation. > > regards, > Raghavendra > _______________________________________________ Gluster-devel mailing list [email protected] http://www.gluster.org/mailman/listinfo/gluster-devel
