Have just 1 comment. Once you answer it, its good to go. On Fri, May 12, 2017 at 9:48 AM, Raghavendra G <[email protected]> wrote:
> I'll wait for a day on this. If there are no reviews, I'll assume that as > a +1 and will go ahead and merge it. If anyone needs more time, please let > me know and I can wait. > > On Thu, May 11, 2017 at 12:22 PM, Raghavendra Gowdappa < > [email protected]> wrote: > >> All, >> >> Reviews are requested on [1]. Impact is non-trivial as it introduces more >> concurrency in execution wrt processing of messages read from network. >> >> All tests are passed, though gerrit is not reflecting the last smoke >> which was successful. >> >> For reference, below is the verbatim copy of commit msg: >> >> <commit> >> >> event/epoll: Add back socket for polling of events immediately after >> reading the entire rpc message from the wire Currently socket is added back >> for future events after higher layers (rpc, xlators etc) have processed the >> message. If message processing involves signficant delay (as in writev >> replies processed by Erasure Coding), performance takes hit. Hence this >> patch modifies transport/socket to add back the socket for polling of >> events immediately after reading the entire rpc message, but before >> notification to higher layers. >> >> credits: Thanks to "Kotresh Hiremath Ravishankar" <[email protected]> >> for assitance in fixing a regression in bitrot caused by this patch. >> >> BUG: 1448364 >> </commit> >> >> @Nigel, >> >> Is there a way to override -1 from smoke, as last instance of it is >> successful? >> >> [1] https://review.gluster.org/#/c/15036/ >> >> regards, >> Raghavendra >> _______________________________________________ >> Gluster-devel mailing list >> [email protected] >> http://lists.gluster.org/mailman/listinfo/gluster-devel >> > > > > -- > Raghavendra G > > _______________________________________________ > Gluster-devel mailing list > [email protected] > http://lists.gluster.org/mailman/listinfo/gluster-devel > -- Amar Tumballi (amarts)
_______________________________________________ Gluster-devel mailing list [email protected] http://lists.gluster.org/mailman/listinfo/gluster-devel
