On 1/24/19 3:23 AM, Soumya Koduri wrote: > Hi Shyam, > > Sorry for the late response. I just realized that we had two more new > APIs glfs_setattr/fsetattr which uses 'struct stat' made public . As > mentioned in one of the patchset review comments, since the goal is to > move to glfs_stat in release-6, do we need to update these APIs as well > to use the new struct? Or shall we retain them in FUTURE for now and > address in next minor release? Please suggest.
So the goal in 6 is to not return stat but glfs_stat in the modified pre/post stat return APIs (instead of making this a 2-step for application consumers). To reach glfs_stat everywhere, we have a few more things to do. I had this patch in my radar, but just like pub_glfs_stat returns stat (hence we made glfs_statx as private), I am seeing this as "fine for now". In the future we only want to return glfs_stat. So for now, we let this API be. The next round of converting stat to glfs_stat would take into account clearing up all such instances. So that all application consumers will need to modify code as required in one shot. Does this answer the concern? and, thanks for bringing this to notice. > > Thanks, > Soumya > >  https://review.gluster.org/#/c/glusterfs/+/21734/ > > > On 1/23/19 8:43 PM, Shyam Ranganathan wrote: >> On 1/23/19 6:03 AM, Ashish Pandey wrote: >>> >>> Following is the patch I am working and targeting - >>> https://review.gluster.org/#/c/glusterfs/+/21933/ >> >> This is a bug fix, and the patch size at the moment is also small in >> lines changed. Hence, even if it misses branching the fix can be >> backported. >> >> Thanks for the heads up! >> _______________________________________________ >> Gluster-devel mailing list >> Glusteremail@example.com >> https://lists.gluster.org/mailman/listinfo/gluster-devel >> _______________________________________________ Gluster-devel mailing list Glusterfirstname.lastname@example.org https://lists.gluster.org/mailman/listinfo/gluster-devel