On Wed, Jan 23, 2013 at 3:08 AM, Raghavendra Bhat <rab...@redhat.com> wrote:
> > Hi, > > syncop_opendir_cbk does not ref the fd while returning unlike > syncop_open_cbk which results in crash due to fd being destroyed early and > then being accessed (bug 885008). A patch has been submitted for review. ( > http://review.gluster.org/#change,4282). Please review it and provide > inputs. > > Doing the extra fd_ref() in syncop_open[dir]_cbk seems to be uglier than thought. I see that it is already resulting in fd ref leak in gfapi. It is safer to remove the extra ref/unref and make open[dir]() return only success or failure with op_ret. Avati
_______________________________________________ Gluster-devel mailing list Gluster-devel@nongnu.org https://lists.nongnu.org/mailman/listinfo/gluster-devel
