https://bugzilla.redhat.com/show_bug.cgi?id=1564149
--- Comment #22 from Xavi Hernandez <[email protected]> --- Some issues I've seen: * Some initializations are formatted like this: char gfid_local[GF_UUID_BUF_SIZE] = { 0, }; I've tried to change AllowShortBlocksOnASingleLine=true, but no change here. * Braces after functions are not put into a new line. It seems that BreakBeforeBraces=Attach has precedence to BraceWrapping.AfterFunction=true. * AlignConsecutiveAssignments=true aligns some assignments inside a function (not only variables initialization at the beginning). I think this is not necessary. * Some assignments are rendered like this: meta_dst->size = hton64(ntoh64(meta_dst->size) + ntoh64(meta_src->size)); meta_dst->file_count = hton64(ntoh64(meta_dst->file_count) + ntoh64(meta_src->file_count)); I think we should increase PenaltyBreakAssignment to prevent this. I've chosen a random value (200) and this is the result: meta_dst->size = hton64(ntoh64(meta_dst->size) + ntoh64(meta_src->size)); meta_dst->file_count = hton64(ntoh64(meta_dst->file_count) + ntoh64(meta_src->file_count)); I'll create a new pull request with these changes. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1tnUHvZJiN&a=cc_unsubscribe _______________________________________________ Gluster-infra mailing list [email protected] http://lists.gluster.org/mailman/listinfo/gluster-infra
