On 9/1/21 22:12, Plaum, Burkhard wrote:
Hi,first of all thanks a lot for the patches. I applied all for gavl already. I have a some problem with the gmerlin manpages: You might have noticed, that they are generated programatically (with the -help-man option), so every change to the *.1 files will be overwritten. Many strings you fixed, come originally from *.c files and should be fixed there. Also It seems, that a dash needs to be escaped with a backslash, right? This can be fixed in cmdline.c, bg_cmdline_print_help(). I could regenerate the manpages because I have the suspicion, that many options are gone anyway (they came from plugins). Would that be an idea?
sounds good.if the manpages are generated via the '-help-man' flag, then tey probably shouldn't be checked into the repository at all? just run generate them at build-time (but make this optional, to allow cross-compilation).
right now it seems that some manpages are in the repository, but others are not.
both approaches have their merits, but i think you should pick one (and traditionally i favour the removal of any generated file from a VCS)
I can also fix bg_cmdline_print_help() if you can give some input what exactly needs to be changed.
traditionally dash ought to be escaped, due to problems on UTF-8the patch itself is rather old it obviously predates the VCS-history of the packaging - which starts in 2010). iirc, the problem manifested itself when trying to copy-paste an option from the manpage, which would then not be recognized by the program.
i'm not entirely sure whether modern versions of groff would handle these dashes correctly. in any case, groff(7) (e.g. [1]) says that an ordinary "minus sign" is supposed to be written as "\-".
and then there is the crasher bug, which i only noticed when running "gmerlin_visualizer -help-man"
mfgasd IOhannes [1] https://linux.die.net/man/7/groffmgsdar
OpenPGP_signature
Description: OpenPGP digital signature
_______________________________________________ Gmerlin-general mailing list Gmerlin-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/gmerlin-general
