[email protected] (Niels Möller) writes: Will you commit these fixes, or do you want me to do that? Please take care of any fixing. It's your baby after all. :-)
I have found the same four direct MPZ_REALLOC problems when reviewing the code: mpz_abs_add, mpz_and, mpz_ior and mpz_xor. Then I have loooked for functions which use cached pointers over a call to a function using MPZ_REALLOC. But I didn't find any problems of that type. These other usages all seem to be safe, I finished a review too, since four eyes see more than two. (I think the mini-gmp test suite should have caught these errors. I'd suggest that you enhance it, and make sure these types of errors are actually detected.) -- Torbjörn _______________________________________________ gmp-devel mailing list [email protected] http://gmplib.org/mailman/listinfo/gmp-devel
