On Mon, Mar 12, 2007 at 08:54:15PM +0100, Udo Giacomozzi wrote: > Monday, March 12, 2007, 8:45:52 PM, I wrote: > UG> Log message: > UG> implement instance names for buttons and text fields > > - the patch basically works but the instance names are not really > correct because button childs get their name immediately whereas > sprites get it only when added to the display list. This means a > unnamed sprite inside a unnamed button gets a name like > _level0.instance2.instance1 > whereas is should be;: > _level0.instance1.instance2 > At least it does get a name now...
Doing this in the ::construct() method should fix this. I'm implementing that for you now, but unfortunately you missed to provide a testcase so is untested. > - Again, when having a sprite inside a button, this sprite can't > currently access the button through "_parent". Don't know where the > problem is (spent a hour digging) but > trace(this._parent) > simply returns nothing (not even "undefined"). A testcase and I'll look at it :) > - I also noticed that with no button at all "this._parent" returns > "_level0." (notice the extra dot). This is a known one, but doesn't seem to be a big problem currently. > I commited what I have in the meanwhile because there should be no > regression anyway and I can't continue working on Gnash until the end > of the week... I confirm no regressions. Thanks. --strk; _______________________________________________ Gnash-commit mailing list [email protected] http://lists.gnu.org/mailman/listinfo/gnash-commit
